Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display triangular matrices with dots #127

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Display triangular matrices with dots #127

merged 2 commits into from
Jan 10, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 3, 2024

After this, the structured zeros of a UpperTriangularToeplitz are displayed with dots, as in a UpperTriangular:

julia> U = UpperTriangularToeplitz([1,2,3,4])
4×4 UpperTriangularToeplitz{Int64, Vector{Int64}}:
 1  2  3  4
   1  2  3
     1  2
       1

This involves extending Base.replace_in_print_matrix, which is internal to Base (although it should perhaps be public).

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02f06e5) 95.61% compared to head (82469f9) 95.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +0.01%     
==========================================
  Files           9        9              
  Lines         957      961       +4     
==========================================
+ Hits          915      919       +4     
  Misses         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Pull Request Test Coverage Report for Build 7470652756

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.63%

Totals Coverage Status
Change from base Build 7470644076: 0.02%
Covered Lines: 919
Relevant Lines: 961

💛 - Coveralls

@jishnub jishnub merged commit e541d9d into master Jan 10, 2024
13 checks passed
@jishnub jishnub deleted the jishnub/dotsdisplay branch January 10, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant