-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract type for matrices wrapping a single vector #98
Abstract type for matrices wrapping a single vector #98
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 94.72% 94.98% +0.26%
==========================================
Files 7 7
Lines 796 798 +2
==========================================
+ Hits 754 758 +4
+ Misses 42 40 -2
☔ View full report in Codecov by Sentry. |
e8b8c8d
to
eb6c504
Compare
Could this idea be extended to a new package, say |
Does that help in general? In this case, we know the structure of the matrices and can forward various functions to the parent. |
for example, "linear" could be too general for most cases. A subtype would be that the values of parent are exactly projected to different locations. |
This might be worth discussing in |
Defining this abstract type would mean that several functions need to only be extended for the abstract type instead of for every concrete subtype. Also, future types subtyping the abstract type get these methods for free.