Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an unifying type for all graph datasets #169

Closed
Dsantra92 opened this issue Sep 1, 2022 · 1 comment
Closed

Make an unifying type for all graph datasets #169

Dsantra92 opened this issue Sep 1, 2022 · 1 comment

Comments

@Dsantra92
Copy link
Collaborator

Dsantra92 commented Sep 1, 2022

It would be good to have something like:

struct GraphDataset <: AbstractDataset
    name::String
    metadata::Dict{String, Any}
    graphs::Vector{Graph}
    graph_data::Union{Nothing,NamedTuple}
end

Instead of individual struct for each dataset. Unifying them would reduce a lot of code duplication.

Also, metadata fields can be adopted from the OGB convention.

cc: @CarloLucibello

@Dsantra92
Copy link
Collaborator Author

Closing this as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant