Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect docs for undersample and oversample #113

Closed
Moelf opened this issue Jul 7, 2022 · 1 comment · Fixed by #116
Closed

Incorrect docs for undersample and oversample #113

Moelf opened this issue Jul 7, 2022 · 1 comment · Fixed by #116

Comments

@Moelf
Copy link

Moelf commented Jul 7, 2022

The docs claims:

MLUtils.jl/src/resample.jl

Lines 133 to 141 in b29bf41

X_bal, Y_bal = undersample(X, Y)
# this results in a smaller dataset
@assert size(X_bal) == (3,4)
@assert length(Y_bal) == 4
# now both "a", and "b" have 2 observations each
@assert sum(Y_bal .== "a") == 2
@assert sum(Y_bal .== "b") == 2

The docs needs to be changed to ((X,Y))

same goes for oversample.

@Moelf
Copy link
Author

Moelf commented Jul 7, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant