Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method ambiguities reported by Aqua #171

Closed
prbzrg opened this issue Dec 27, 2023 · 0 comments · Fixed by #172
Closed

Method ambiguities reported by Aqua #171

prbzrg opened this issue Dec 27, 2023 · 0 comments · Fixed by #172

Comments

@prbzrg
Copy link

prbzrg commented Dec 27, 2023

In Julia v1.10, I used Aqua to detect method ambiguities in my package impICNF/ContinuousNormalizingFlows.jl#356 and some of its report were related to this package:

Ambiguity #94
put!(f!, ringbuffer::MLUtils.RingBuffer) @ MLUtils ~/.julia/packages/MLUtils/n3C0h/src/parallel.jl:219
put!(c::Channel{T}, v) where T @ Base channels.jl:339

Possible fix, define
  put!(::Channel{T}, ::MLUtils.RingBuffer) where T

Ambiguity #100
rpad(v::AbstractVector, n::Integer, p) @ MLUtils deprecated.jl:103
rpad(s, n::Integer, p::Union{AbstractChar, AbstractString}) @ Base strings/util.jl:485

Possible fix, define
  rpad(::AbstractVector, ::Integer, ::Union{AbstractChar, AbstractString})

I would appreciate your attention to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant