-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing transforms #13
Comments
Hi! I am going to try implementing a I am kinda of an Beginner-Intermediate in julia. Incidentally I was reading about Transducers and watching Rich Hickey talk about them hours before I found this issue on the good-first-issues on Julia's homepage. |
Awesome @Omar-Elrefaei, welcome to the Julia community! :) Below is the signature of the struct Rename <: Stateless
names::Dict{Symbol,Symbol}
end This will create a default constructor that works like Rename(Dict(:col1 => :newcol1, :col2 => :newcol2)) After we have this struct holding a dictionary with symbols, we need to implement Let me know if you need any help. |
By the way, what web page is mentioning our issues as good first issues? |
Thanks for the warm welcome @juliohm. At the bottom of julialang.org there is a link to good first issues |
Interesting, wasn't aware of this link, thanks. |
@Omar-Elrefaei any update on this? If you can start working on a PR it will be easier for us to review while you evolve the solution. Many first-time contributors try to develop a feature on their own in isolation just to discover that radical changes to the design are necessary later. If you open a PR and continue pushing commits to the branch, GitHub will update and will allow reviewers guide you in the process. |
Yes, I definitely agree. I do semi-regularly make that mistake of banging my head on the wall too much instead of just asking questions. Anyway PR is sent. |
Thank you @Omar-Elrefaei for adding a new transform to the list. Feel free to pick any other from the list. The |
We are only missing Replace, Coalesce and Coerce for a v1.0 release 👍🏽 |
What is the expected behavior of |
What would syntax of the
Or do we also provide what columns to work on:
This wouldn't work well, because we have no way of specifying what values to replace in which column. Pandas has a solution to this. |
They are the equivalent of Base.coalesce and Scitypes.coerce. @eliascarv is already working on the Coalesce, which is related to Replace. For Coerce we just need to forward the arguments to Scitypes.coerce. Do you want to work on that @ceferisbarov ? |
Thanks for the response. Yes, I do. @juliohm |
Great job everyone, this issue is now complete. Let's open new issues for specific transforms in the future. |
Below is a list of transforms to be implemented:
Contributions are very welcome! Just comment on the issue if you plan to start working on some of these.
The text was updated successfully, but these errors were encountered: