Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safety #134

Open
antoine-levitt opened this issue Jan 24, 2020 · 2 comments
Open

Thread safety #134

antoine-levitt opened this issue Jan 24, 2020 · 2 comments

Comments

@antoine-levitt
Copy link
Contributor

#105 suggests that planning is thread-safe. I just had a memory error in my code that was caused by me calling ldiv!(x,p,y) on an existing plan (which calls FFTW's planner). Backtrace here: https://gist.github.com/antoine-levitt/18e80e5de607158f65ee4022967a8a6b. Is this expected? If yes, it should be documented somewhere what exactly is type-safe and what is not in the API.
@antoine-levitt
Copy link
Contributor Author

Should mention: this is on julia 1.3.0, FFTW 1.2.0

@antoine-levitt antoine-levitt mentioned this issue Jan 24, 2020
Merged
@stevengj
Copy link
Member

Maybe we need a lock around mutating the Plan object to cache the inverse plan in ldiv

@kczimm kczimm mentioned this issue Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoine-levitt @stevengj