Clean ups, dead code removal #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure that this is related to, e.g., JuMPeR.Uncertain. There were some odd methods defined with a reference to Julia 0.4, and sure enough deleting them changed nothing (test-wise). JuMPScalars was unused entirely. JuMPTypes was used only in operators.jl, so I moved it there.
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=========================================
+ Coverage 89.33% 89.4% +0.07%
=========================================
Files 25 25
Lines 3562 3559 -3
=========================================
Hits 3182 3182
+ Misses 380 377 -3
Continue to review full report at Codecov.
|
mlubin
approved these changes
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.