Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect assert (fixes #1561) #1565

Merged
merged 1 commit into from Oct 27, 2018
Merged

remove incorrect assert (fixes #1561) #1565

merged 1 commit into from Oct 27, 2018

Conversation

mlubin
Copy link
Member

@mlubin mlubin commented Oct 26, 2018

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #1565 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
+ Coverage   89.49%   89.54%   +0.05%     
==========================================
  Files          27       27              
  Lines        3626     3625       -1     
==========================================
+ Hits         3245     3246       +1     
+ Misses        381      379       -2
Impacted Files Coverage Δ
src/nlp.jl 90.82% <ø> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c36bf2...d497114. Read the comment docs.

@mlubin mlubin merged commit 3c5e378 into master Oct 27, 2018
@mlubin mlubin deleted the ml/assert branch October 27, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant