Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old examples that require calbacks #1697

Merged
merged 1 commit into from Dec 21, 2018
Merged

Remove old examples that require calbacks #1697

merged 1 commit into from Dec 21, 2018

Conversation

odow
Copy link
Member

@odow odow commented Dec 20, 2018

These examples are old, require commercial solvers, and use the callback functionality that has been removed in JuMP-0.19.

They still exist in the 0.18 branch so can be easily revived if/when callbacks are re-introduced.

Closes #1689

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1697   +/-   ##
=======================================
  Coverage   68.52%   68.52%           
=======================================
  Files          30       30           
  Lines        3867     3867           
=======================================
  Hits         2650     2650           
  Misses       1217     1217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32fce7...8deb447. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1697   +/-   ##
=======================================
  Coverage   68.52%   68.52%           
=======================================
  Files          30       30           
  Lines        3867     3867           
=======================================
  Hits         2650     2650           
  Misses       1217     1217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32fce7...8deb447. Read the comment docs.

@IainNZ
Copy link
Collaborator

IainNZ commented Dec 21, 2018

RIP that tsp code, I remember setting it up behind HttpServer.jl do demonstrate "TSP as a service"!

@mlubin mlubin merged commit b78da67 into master Dec 21, 2018
@mlubin mlubin deleted the od/examples branch December 21, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants