Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type parameters for MDP and POMDP #475

Closed
zsunberg opened this issue Apr 14, 2023 · 1 comment
Closed

Remove type parameters for MDP and POMDP #475

zsunberg opened this issue Apr 14, 2023 · 1 comment

Comments

@zsunberg
Copy link
Member

Currently we have MDP{S, A} and POMDP{S, A, O}. The type parameters don't serve much of a purpose.

This was convenient when the only way to define an MDP or POMDP was using the object-oriented method because it saved users from having to specify statetype, actiontype and obstype, but now QuickPOMDPs can detect this automatically.

Instead, we should just require that new problem types implement the XXXtype functions directly.

@zsunberg
Copy link
Member Author

Though this was probably a mistake in hindsight, it would be difficult to fix and only offer a very small benefit, so I'm going to classify it as not-planned for now.

@zsunberg zsunberg closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant