Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow RGB inputs for heatmap #2036

Merged
merged 5 commits into from Jun 14, 2022
Merged

allow RGB inputs for heatmap #2036

merged 5 commits into from Jun 14, 2022

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jun 9, 2022

Description

Fixes #2033

Adds support for heatmap(xs, ys, img) (back?)

Type of change

New feature / Bug fix

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Jun 9, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt.

using time

master:  8.76 < 8.81 > 8.86, 0.04+-
pr:      8.74 < 8.76 > 8.86, 0.04+-
speedup: 0.99 < 1.00 > 1.01, 0.01+-
median:  -0.56% => invariant

This PR does not change the using time.

ttfp time

master   24.69 < 24.87 > 25.11, 0.13+-
pr       24.77 < 24.84 > 25.01, 0.10+-
speedup: 0.99 < 1.00 > 1.01, 0.01+-
median:  -0.10% => invariant

This PR does not change the ttfp time.

@ffreyer
Copy link
Collaborator Author

ffreyer commented Jun 9, 2022

All test failures are because I added a new refimg

@juliohm
Copy link
Member

juliohm commented Jun 9, 2022

Thank you @ffreyer for fixing the issue, appreciate it.

@juliohm
Copy link
Member

juliohm commented Jun 10, 2022

Can this PR be merged?

@ffreyer
Copy link
Collaborator Author

ffreyer commented Jun 10, 2022

Yes, it's ready to be merged. I just need someone to review it

@juliohm
Copy link
Member

juliohm commented Jun 10, 2022

@SimonDanisch can you please take a look at this PR?

@juliohm
Copy link
Member

juliohm commented Jun 12, 2022

This PR contains a hot fix for an important issue. Appreciate if someone can review it.

Thank you again @ffreyer for the quick fix.

@SimonDanisch SimonDanisch merged commit 31fd1a6 into master Jun 14, 2022
@SimonDanisch SimonDanisch deleted the ff/heatmap branch June 14, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while rendering a heatmap with RGB z-matrix
4 participants