Fix per character attributes in text #2244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This example currently throws an error which is fixed by this pr:
This happens because
https://github.com/JuliaPlots/Makie.jl/blob/bfe128ee1535ad75a4bab6109826caa08ba5f4de/src/basic_recipes/text.jl#L34
generates a
1:1
range for strings which is incompatible with the length twocolor
vector. Afaik all the per character stuff happens inglyph_collection
(orlayout_text
) so I just added a branch without the broadcasting fortext::String
. This seems to work fine for scalar and vector inputs or text and latex text.Type of change
Delete options that do not apply:
Checklist