Waterfall recipe

[daschw]

Description

This is the implementation of waterfall charts as a recipe as discussed with @jkrumbiegel in #2314.
Not sure, if the amount and naming of specific attributes is OK;
It adds the following examples to the docs:

using Makie

y = [6, 4, 2, -8, 3, 5, 1, -2, -3, 7]

waterfall(y)

waterfall(y, show_direction=true)

waterfall(y, show_direction=true, marker_pos=:cross, marker_neg=:hline, direction_color=:gold)

x = repeat(1:2, inner=5)
group = repeat(1:5, outer=2)
colors = Makie.wong_colors()

waterfall(x, y, dodge=group, color=colors[group])

waterfall(x, y, dodge=group, color=colors[group], show_direction=true, show_final=true)

waterfall(x, y, dodge=group, color=colors[group], show_final=true, final_color=(colors[6], 1//3))

waterfall(group, y, dodge=x, color=colors[x], stack=:x, show_direction=true)

Type of change

Delete options that do not apply:

• New feature (non-breaking change which adds functionality)

Checklist

• Added an entry in NEWS.md (for new features and breaking changes)
• Added or changed relevant sections in the documentation
• Added unit tests for new algorithms, conversion methods, etc.
• Added reference image tests for new plotting functions, recipes, visual options, etc.

[SimonDanisch]

You should turn all the fromto[]/marker[]/etc into: lift(x-> x.xy, fromto)

[daschw]

Thanks for the hint! Does this also apply to p.show_final[], p.final_gap[] etc?

[SimonDanisch]

Yes, but there you should be able to just remove the []

[daschw]

Hm, but if I remove [] e.g. in L58, I get

ERROR: TypeError: non-boolean (Observable{Any}) used in boolean context

[SimonDanisch]

Yeah only remove it when passing it to another plotting function, not actually when using it in an if ;) It's still an observable after all, and not a boolean

[daschw]

bump: I added more lifts in the recipe as suggested by Simon. Is there anything else I should change to move this forward?