-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing deprecated and broken backends #1831
Comments
I essentially did that under vizcon: https://github.com/JuliaPlots/Plots.jl/pull/1818/files HDF5 is not really a backend - it's an implementation of the HDF5 save format for Plots that is implemented as a backend for clarity. |
Ah, right - great! What about plotly(js) though - I heard they were broken, currently? I agree regarding HDF5, I thought about that myself while I overhauled the package init. It should be represented as an output format (and so far the only input format) for plots, now matter what backend they were generated with, instead of being a backend itself. @ma-laforge , I think you implemented most of it, what do you think, regarding HDF5? |
I believe PlotlyJS is fixed now |
Great! So the only question is indeed whether to keep inspectdr - does anyone know what it's status is (@ma-laforge maybe)? |
Wow, there's an important one missing from our links - UnicodePlots! @Evizero is that working for 1.0? I get some errors when I try it. |
Oh, yes - UnicodePlots will definitely stay, of course! |
UnicodePlots should work in 1.0 without issues. I am guessing you mean the Plots backend? I know nothing about that. That said I am in the process of upgrading UnicodePlots a bit (finally writing proper tests and such). Once that is done and merged I will look at the Plots backend code a bit and see what I can do. |
Great! |
I created HDF5-Plots as a backend simply because it was the simplest way for me to hook into the module. The Plots.jl is quite complex, and I did not want to break anything, however...
I also did it that way because, by making HDF5-plots into a backend, I figured the idea was less likely to be rejected since the backend does not have tenticles all over the code base :). That being said, I am not particularly attached to the way HDF5-plots was implemented. Why are the base plot objects tied to a backend??That is my question. I see the need to have an object tied to a backend only for display purposes (ie so that the right backend gets called when you
? If we had truly backend-agnostic plot objects (where all properties were stored natively), then there would be no reason for HDF5-plots to be masquerading as a backend. |
However, the comments I have received indicate that those who use InspectDR either like:
As far as I can see it appears the other backends do not have the same level of speed/interactivity yet. |
I also think we should keep inspect-dr, @ma-laforge is very responsive to issues and it is almost 0 maintenance for us, and it does have a userbase. Also, yes, it would be possible (and a good idea) to have backend-free plot objects, and in fact that was a vision of Tom Breloff's. It was discussed most recently as a year ago #390 |
Yes, I've bee thinking about that - I want to look into a few things to reduce time to first plot, and was looking into possible structural changes. I have a feeling that the Plot struct doesn't need to be parameterized by backend type. Then one could simply plot with a no-op backend, save the plot to HDF5, load it in another session and then show it with any backend. |
Sure, if it's working and actively maintained, then definitely. |
While trying to reduce the load time of Plots, I realized there may be a chance to also reduce the time spent in code-gen. Not sure, but I'd like to try. However, it would be much easier without lots of broken and deprecated backends.
Maybe it's time to rip out all of those defunct/deprecated backends right now? Which backends should we keep?
The text was updated successfully, but these errors were encountered: