Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@gif and @animate macro hygiene #2143

Closed
sefffal opened this issue Aug 14, 2019 · 3 comments
Closed

@gif and @animate macro hygiene #2143

sefffal opened this issue Aug 14, 2019 · 3 comments
Labels

Comments

@sefffal
Copy link
Contributor

sefffal commented Aug 14, 2019

Let me preface this by saying thank you to the maintainers of Plots.jl! I've been using it heavily for months and this is really the first issue I've noticed, so thanks for all your hard work.

version: 0.26.1

Currently, if the user has a variable named frame defined then the at-gif macro will fail because it tries to use that instead of the Plots.frame function.

Looking at the @gif macro, I think this could be fixed by changing frame to Plots.frame. This probably applies to the call to Animation() as well, and maybe the at-animate macro too.

@asinghvi17
Copy link
Member

Would be great if you can open a PR for this - seems like a pretty simple fix! We'd be happy to help if you run into any issues :)

@sefffal
Copy link
Contributor Author

sefffal commented Aug 16, 2019

Sounds good, thanks! I’ll take a look and see what I can do.

@t-bltg t-bltg added the bug label Nov 24, 2022
@t-bltg
Copy link
Member

t-bltg commented Nov 24, 2022

Seems fixed.

@t-bltg t-bltg closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants