Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Remove camera limitation for GR backend #4224

Closed
BeastyBlacksmith opened this issue Jun 2, 2022 · 0 comments · Fixed by #4232
Closed

[FR] Remove camera limitation for GR backend #4224

BeastyBlacksmith opened this issue Jun 2, 2022 · 0 comments · Fixed by #4232
Labels
enhancement improving existing functionality GR

Comments

@BeastyBlacksmith
Copy link
Member

It would be a small change if Plots.jl would use GR's axis function:

        ###warn_invalid(val) =
        ###    if val < 0 || val > 90
        ###        @warn "camera: $(val)° ∉ [0°, 90°]"
        ###    end
        ###warn_invalid.(camera)

        ###GR.setspace(zmin, zmax, camera...)
        GR.setwindow3d(xmin, xmax, ymin, ymax, zmin, zmax)
        GR.setspace3d(-camera[1], camera[2], 30, 0)

We'd have to look into if we can use the GR axis or identify what is missing.

CC: @jheinen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing functionality GR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant