New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dependency on DataValues.jl #534

Closed

svilupp opened this issue Apr 26, 2023 · 0 comments · Fixed by #535

Contributor

svilupp commented Apr 26, 2023

Would it be acceptable to remove DataValues.jl from the dependencies?

Benefits:

it's not used (ie, unnecessary dep to resolve)
it brings a lot of method invalidations (see Reduce invalidations queryverse/DataValues.jl#84) slowing down the package imports

Counterarguments:

?

The text was updated successfully, but these errors were encountered:

svilupp mentioned this issue

Remove dependency on DataValues.jl #535

Merged

sethaxen closed this as completed in #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment