Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyCall 1.96.2 breaks tests at Imbalance.jl #1064

Closed
ablaom opened this issue Dec 4, 2023 · 5 comments · Fixed by #1065
Closed

PyCall 1.96.2 breaks tests at Imbalance.jl #1064

ablaom opened this issue Dec 4, 2023 · 5 comments · Fixed by #1065

Comments

@ablaom
Copy link

ablaom commented Dec 4, 2023

I can reproduce the following CI fail on my mac under Julia 1.9.1 and julia 1.6.5 (errors are slightly different):

https://github.com/JuliaAI/Imbalance.jl/actions/runs/6949846973/job/18908791611

However, if I pin PyCall to 1.96.1 then tests pass locally on my machine.

@ablaom
Copy link
Author

ablaom commented Dec 4, 2023

(PyCall is only a test dependency of Imbalance.jl)

@stevengj
Copy link
Member

stevengj commented Dec 5, 2023

Nowadays you need to put version numbers for your stdlibs, and it looks like PyCall doing so broke your package:

https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958

Maybe update your Project.toml with the new recommended compat entries?

@ablaom
Copy link
Author

ablaom commented Dec 5, 2023

Thanks @stevengj . The strange thing is that that some standard libraries that appear in the error messages (which ones appear to change depending on Julia version) are not even used in the package or in tests. So, for example, Libdl and Dates.

@EssamWisam Do you want to see if adding compats for our stdlibs makes any difference? I think they are just Statistics, Random, and LinearAlgebra.

@EssamWisam
Copy link

EssamWisam commented Dec 5, 2023

@EssamWisam Do you want to see if adding compats for our stdlibs makes any difference? I think they are just Statistics, Random, and LinearAlgebra.

Will try. I suppose I should be using the most recent versions.
@ablaom Quite confused, they don't seem to have versions (or just 1.6?). Pkg.Status("LinearAlgebra") doesn't give any version.

@ablaom
Copy link
Author

ablaom commented Dec 5, 2023

Yeah, in even in Julia 1.9.1 some libraries (e.g, Random) don't even show a version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants