-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-entrancy issue in new pycall! #533
Comments
On an unrelated note, it looks like the Python arguments never get garbage-collected. Correction: |
Nice subtle bug, glad you found it. As you might recall I did mention the non-threadsafe situation in #483 (comment), but I hadn't considered that
Ahh! Makes sense now. Anyway, great work as usual, #534 lgtm. |
Because the new
pycall!
implementation in #492 uses a global cache of Python tuples, we encounter some sticky problems due to lack of re-entrancy. In particular, if thePyObject
call inpysetarg!
itself callspycall
with the same number of arguments, we get the wrong results.This can happen with the range conversions:
cc @JobJob
The text was updated successfully, but these errors were encountered: