Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

referencing of column names needs to be standardized #29

Closed
XilinJia opened this issue Mar 27, 2014 · 2 comments
Closed

referencing of column names needs to be standardized #29

XilinJia opened this issue Mar 27, 2014 · 2 comments

Comments

@XilinJia
Copy link
Contributor

In both cci and keltnerbands, columns are referenced by the names such as "High", "Close" etc. This is based on the assumption that the data come with these names. How do we ensure about this assumption? Somewhere this needs to be addressed.

@milktrader
Copy link
Member

You should also observe the µprice method that calculates the typical price. This is a very common calculation in technical analysis but I think the name I gave it is unfortunately too obtuse.

We could possibly apply a regex to capture High, Hi, high, hi in a newly named µprice method. Another solution is to pass kwargs where these strings are explicitly defined.

What do you think?

@milktrader
Copy link
Member

Standardizing on typical method.#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants