Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies that depend on each other #402

Open
shashi opened this issue Nov 10, 2021 · 0 comments
Open

Updating dependencies that depend on each other #402

shashi opened this issue Nov 10, 2021 · 0 comments

Comments

@shashi
Copy link

shashi commented Nov 10, 2021

Take the example of NeuralPDE.jl https://github.com/SciML/NeuralPDE.jl/blob/master/Project.toml

it depends on SymbolicUtils, Symbolics, and ModelingToolkit

ModelingToolkit = "6.3.1, 6"
SymbolicUtils = "0.13, 0.14, 0.15, 0.16"
Symbolics = "3"

And Symbolics depends on SymbolicUtils, and ModelingToolkit (MTK) depends on both SymbolicUtils and Symbolics.

  1. version v0.18 of SymbolicUtils was released
    CompatHelper opened a PRs 1 bumping the version in Symbolics, MTK and NeuralPDE, but the CI for this will fail because NeuralPDE depends on a Symbolics that does not yet support SymbolicUtils v0.18
  2. a couple of days later Symbolics was updated to use it and generated a breaking release of Symbolics -- v4.0
    CompatHelper opened a PRs 2 bumping only Symbolics in MTK and NeuralPDE, now the CI for this PR (which in theory should be good to go on MTK) will fail because the previous PR updating SU was not yet merged because it cannot be tested.
  3. a few days later we manually updated ModelingToolkit and released version 7.0.0, at which point new PRs 3 was generated on NeuralPDE bumping only the MTK version -- again untestable because they still depend on Symbolics and SymbolicUtils which are not compatible with the new version of MTK.

A good solution would be:

When opening a version bump of Symbolics (v4.0) on package X, make sure that X all dependencies X and Symbolics share are also bumped to the highest version Symbolics requires in the same PR.

In this way the 3rd PR at least can be tested by CI.

Further, it can also be useful to just close the old PR (bumping SymbolicUtils) automatically when a new PR like the above bumps both Symbolics and SymbolicUtils together.

maybe related to #126 and others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant