Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing instructions from JuliaRegistrator #319

Open
cscherrer opened this issue Jan 23, 2021 · 7 comments
Open

Confusing instructions from JuliaRegistrator #319

cscherrer opened this issue Jan 23, 2021 · 7 comments

Comments

@cscherrer
Copy link

Hi, I found this warning message really confusing:

Also, note the warning: Version 0.1.3 skips over 0.1.2
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

There's some discussion on it here:
https://discourse.julialang.org/t/confusing-instructions-from-juliaregistrator/53833

Thanks @ericphanson :)

@DilumAluthge
Copy link
Member

I think this is for Registrator.jl, right?

@DilumAluthge DilumAluthge transferred this issue from JuliaRegistries/RegistryCI.jl Jan 23, 2021
@ericphanson
Copy link
Member

No, I think it’s a RegistryCI issue, since the confusing wording is in the automerge message

@DilumAluthge
Copy link
Member

I believe the wording in question is in the Registrator comment, right?

@cscherrer Is this what you're referring to? cscherrer/NestedTuples.jl@cf2fcc2#commitcomment-46276353

@cscherrer
Copy link
Author

@DilumAluthge yep that's it

@DilumAluthge
Copy link
Member

Now that we have AutoMerge, maybe we should just remove this message from Registrator.

@ericphanson
Copy link
Member

Whoops, I mixed it up with the automerge comment. Agreed that it’s better for these to be just in one place, ie in the automerge message(except for errors where it’s actually not going to open the PR or something like that).

@DilumAluthge
Copy link
Member

Whoops, I mixed it up with the automerge comment. Agreed that it’s better for these to be just in one place, ie in the automerge message(except for errors where it’s actually not going to open the PR or something like that).

I agree. All warnings and non-fatal errors should go in the AutoMerge comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants