Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not play nicely with Threads.@spawn or Threads.@threads #25

Open
chriselrod opened this issue May 6, 2021 · 0 comments
Open

Does not play nicely with Threads.@spawn or Threads.@threads #25

chriselrod opened this issue May 6, 2021 · 0 comments

Comments

@chriselrod
Copy link
Member

Two problems:

  1. Possible race conditions. @tkf suggested a good fix here, which is to have a "job started" stated. Then, if the job hasn't started, ThreadingUtilitilies.wait can steal the task back (note that the overhead on this will be much higher than that of a proper work stealing implementation, which would use jumps).
  2. ThreadingUtilities' tasks currently still spend some time before going to sleep. This gets in the way of Threads.@spawn and Threads.@threads, causing bad performance. It'd be great if there were something they could check to go to sleep immediately if someone used Thread.@spawn or Threads.@threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant