Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with docstring of accuracy function #33

Closed
farhadrclass opened this issue Jul 6, 2022 · 2 comments
Closed

Issue with docstring of accuracy function #33

farhadrclass opened this issue Jul 6, 2022 · 2 comments
Assignees

Comments

@farhadrclass
Copy link
Contributor

The doc string mentioned it uses whole test datasets but the code suggests that it uses the mini_batch_test.
I think we need to either remove the docstring and write a new one or include the functionality

@dpo
Copy link
Member

dpo commented Jul 6, 2022

The docstring is quite confusing:

Compute the accuracy of the network nlp.chain given the data in nlp.minibatch_test. The computation of accuracy is based on the whole test dataset nlp.data_test.

It says that it uses the test minibatch, but then it says that it uses the whole test dataset.

The code certainly suggests that it uses the test minibatch:

Knet.accuracy(nlp.chain; data = nlp.minibatch_test)

I think it should simply use the whole dataset and the docstring should be fixed.

@dpo
Copy link
Member

dpo commented Jul 6, 2022

Fixed in #34 and #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants