-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove (unused) named
kwarg from ranef
#469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 23 23
Lines 1742 1742
=======================================
Hits 1617 1617
Misses 125 125
Continue to review full report at Codecov.
|
""" | ||
function ranef(m::LinearMixedModel{T}; uscale = false, named = false) where {T} | ||
function ranef(m::LinearMixedModel{T}; uscale = false) where {T} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function ranef(m::LinearMixedModel{T}; uscale = false) where {T} | |
function ranef(m::LinearMixedModel{T}; uscale = false, named = nothing) where {T} | |
if named !== nothing | |
Base.depwarn("the `named` keyword argument is deprecated; it has no effect", :ranef) | |
end |
This avoids making a breaking change, since user code currently calling ranef(...; named=true)
will error if the argument is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is queued for 4.0, which has other breaking changes.... but this would provide increased backwards compatibility (as most of the breaking changes are in the internal representation that the average user won't touch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah if it's queued for a breaking release, might as well break it 😄
(cherry picked from commit e14078a)
Closes #467