Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortestcovint for MixedModelBootstrap objects #484

Merged
merged 5 commits into from
Mar 8, 2021
Merged

shortestcovint for MixedModelBootstrap objects #484

merged 5 commits into from
Mar 8, 2021

Conversation

palday
Copy link
Member

@palday palday commented Mar 8, 2021

Doing this is as a 3.x release, but I'll of course port this into the development version. I think it's useful enough for an immediate release.

This also contains a few other fixes:

  • the doc fix from docfix: allpars returns a column table #483
  • the TagBot release notes now strongly suggest that users look at NEWS rather than the closed issues/PRs because those can include changes to other parallel development streams.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #484 (6252ea5) into v3.x (5cd943d) will increase coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v3.x     #484      +/-   ##
==========================================
+ Coverage   93.31%   93.32%   +0.01%     
==========================================
  Files          24       24              
  Lines        1869     1888      +19     
==========================================
+ Hits         1744     1762      +18     
- Misses        125      126       +1     
Impacted Files Coverage Δ
src/bootstrap.jl 97.61% <94.73%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd943d...ddd539f. Read the comment docs.

@palday palday requested a review from dmbates March 8, 2021 13:16
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks for thinking of doing this. It helps to have fewer situations where we require Dataframes.

@palday palday merged commit 4218789 into v3.x Mar 8, 2021
@palday palday deleted the pa/confint branch March 8, 2021 16:09
palday added a commit that referenced this pull request Mar 8, 2021
* shortestcovint for MixedModelBootstrap objects

* news update

* minor version bump

* release notes text update

* showcase new method in docs

(cherry picked from commit 4218789)
palday added a commit that referenced this pull request Mar 10, 2021
* shortestcovint for MixedModelBootstrap objects (#484)

* shortestcovint for MixedModelBootstrap objects

* news update

* minor version bump

* release notes text update

* showcase new method in docs

(cherry picked from commit 4218789)

* update NEWS

* Apply suggestions from code review

Co-authored-by: Douglas Bates <dmbates@gmail.com>

Co-authored-by: Douglas Bates <dmbates@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants