Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response family/distribution to GLMM type parameter #490

Merged
merged 8 commits into from Mar 22, 2021
Merged

Conversation

palday
Copy link
Member

@palday palday commented Mar 18, 2021

Closes #463

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #490 (4ad5555) into master (606ff9d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4ad5555 differs from pull request most recent head 7bf2899. Consider uploading reports for the commit 7bf2899 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          27       27           
  Lines        2151     2152    +1     
=======================================
+ Hits         2021     2022    +1     
  Misses        130      130           
Impacted Files Coverage Δ
src/generalizedlinearmixedmodel.jl 89.23% <100.00%> (+0.07%) ⬆️
src/likelihoodratiotest.jl 97.61% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606ff9d...7bf2899. Read the comment docs.

@dmbates
Copy link
Collaborator

dmbates commented Mar 22, 2021

Shall we merge this now?

@palday
Copy link
Member Author

palday commented Mar 22, 2021

I need to add a NEWS entry 😊 . I'll merge shortly

@dmbates
Copy link
Collaborator

dmbates commented Mar 22, 2021

Okay, thanks.

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Douglas Bates <dmbates@gmail.com>
@palday palday merged commit 12a8590 into master Mar 22, 2021
@palday palday deleted the pa/glmmdist branch March 22, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Distribution/Family Part of the Type Parameter for GLMM
2 participants