Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ProgressBar for logs and when requested #495

Merged
merged 3 commits into from Mar 26, 2021
Merged

Disable ProgressBar for logs and when requested #495

merged 3 commits into from Mar 26, 2021

Conversation

palday
Copy link
Member

@palday palday commented Mar 25, 2021

This requires a new compatibility lowerbound for ProgressMeter.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #495 (a350e9c) into main (db2274d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   93.95%   93.96%           
=======================================
  Files          27       27           
  Lines        2152     2155    +3     
=======================================
+ Hits         2022     2025    +3     
  Misses        130      130           
Impacted Files Coverage Δ
src/bootstrap.jl 97.82% <100.00%> (ø)
src/utilities.jl 95.74% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2274d...a350e9c. Read the comment docs.

@palday palday requested a review from dmbates March 25, 2021 21:14
@palday palday merged commit b9c73da into main Mar 26, 2021
@palday palday deleted the pa/progbar branch March 26, 2021 17:27
palday added a commit that referenced this pull request Mar 26, 2021
* Disable ProgressBar for logs and when requested

* NEWS entry

(cherry picked from commit b9c73da)
palday added a commit that referenced this pull request Mar 26, 2021
* the trunk is now called main (#494)

(cherry picked from commit db2274d)

* update standard tests to include 1.6 (#496)

* update standard tests to include 1.6

* tweak readme

(cherry picked from commit 50ea7a6)

* Update Tier1.yml (#497)

Upload codecov from version 1.6

(cherry picked from commit 5402ae5)

* Disable ProgressBar for logs and when requested (#495)

* Disable ProgressBar for logs and when requested

* NEWS entry

(cherry picked from commit b9c73da)

* Threading improvements (#493)

* better safety in nested threading

* SpinLock brings back the speeeed

* NEWS entry

(cherry picked from commit 624805c)

* minor version bump

Co-authored-by: Douglas Bates <dmbates@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants