Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit lowerbound on beta for GLMM bootstrap #518

Merged
merged 2 commits into from May 10, 2021
Merged

omit lowerbound on beta for GLMM bootstrap #518

merged 2 commits into from May 10, 2021

Conversation

palday
Copy link
Member

@palday palday commented May 10, 2021

Closes #517

Turns out that we were always copying the right parameters, just not the right lower bound for fast=slow fits.

@palday palday requested a review from dmbates May 10, 2021 20:08
@palday palday changed the title omit lowerbod on beta for GLMM bootstrap omit lowerbound on beta for GLMM bootstrap May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #518 (a5628a1) into main (cbcc1e1) will not change coverage.
The diff coverage is n/a.

❗ Current head a5628a1 differs from pull request most recent head db887d6. Consider uploading reports for the commit db887d6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          26       26           
  Lines        2296     2296           
=======================================
  Hits         2164     2164           
  Misses        132      132           
Impacted Files Coverage Δ
src/bootstrap.jl 97.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbcc1e1...db887d6. Read the comment docs.

@palday palday merged commit a3c33de into main May 10, 2021
@palday palday deleted the pa/glmmboot branch May 10, 2021 20:35
palday added a commit that referenced this pull request May 10, 2021
* omit lowerbod on beta for GLMM bootstrap

* news update

(cherry picked from commit a3c33de)
palday added a commit that referenced this pull request May 10, 2021
* Remove DataFramesMeta from the docs (#515)

* fix reflink

* remove DataFramesMeta from the docs

(cherry picked from commit 628cbf3)

* CompatHelper: bump compat for "Distributions" to "0.25" (#516)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 16bb7fb)

* Add sparseL extractor and use it in condVar (#492)

* Add sparseL extractor and use it in condVar

* Add and export condVarTables.  Comment out failing tests.

* update version bound for condVar

* make cvtbl internal

* remove some unused type restrictions

* Remove guards on code for v1.7.0-DEV

* Add tests of convVartable

Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
(cherry picked from commit cbcc1e1)

* omit lowerbound on beta for GLMM bootstrap (#518)

* news update

(cherry picked from commit a3c33de)

* NEWS links

* minor version bump

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Douglas Bates <dmbates@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage of Parameter Vector for GLMM Bootstrap
2 participants