-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster leverage function #553
Conversation
dmbates
commented
Aug 18, 2021
- at present this only works for a single grouping factor - the P.R. is mainly to show the outline
- needs tests, extension, much cleaning up
- and, of course, needs to be mentioned in NEWS.md
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 96.05% 96.14% +0.09%
==========================================
Files 27 27
Lines 2456 2488 +32
==========================================
+ Hits 2359 2392 +33
+ Misses 97 96 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does make the power of the 3 block set up much more obvious
Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
Loosen the tolerance on a comparison of effective degrees of freedom. This calculation seems unstable.
Be more careful with my fractions.