Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster leverage function #553

Merged
merged 10 commits into from Aug 22, 2021
Merged

Faster leverage function #553

merged 10 commits into from Aug 22, 2021

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Aug 18, 2021

  • at present this only works for a single grouping factor - the P.R. is mainly to show the outline
  • needs tests, extension, much cleaning up
  • and, of course, needs to be mentioned in NEWS.md

@dmbates dmbates marked this pull request as draft August 18, 2021 00:42
@palday palday mentioned this pull request Aug 19, 2021
35 tasks
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #553 (c29cc03) into main (ace7f89) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head c29cc03 differs from pull request most recent head a80a2a5. Consider uploading reports for the commit a80a2a5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   96.05%   96.14%   +0.09%     
==========================================
  Files          27       27              
  Lines        2456     2488      +32     
==========================================
+ Hits         2359     2392      +33     
+ Misses         97       96       -1     
Impacted Files Coverage Δ
src/linearmixedmodel.jl 97.84% <100.00%> (+0.13%) ⬆️
src/Xymat.jl 90.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace7f89...a80a2a5. Read the comment docs.

@dmbates dmbates requested a review from palday August 20, 2021 17:34
@dmbates dmbates marked this pull request as ready for review August 20, 2021 17:47
Copy link
Member

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make the power of the 3 block set up much more obvious

src/linearmixedmodel.jl Outdated Show resolved Hide resolved
src/linearmixedmodel.jl Outdated Show resolved Hide resolved
test/pls.jl Outdated Show resolved Hide resolved
test/pls.jl Outdated Show resolved Hide resolved
dmbates and others added 3 commits August 20, 2021 18:12
Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
Loosen the tolerance on a comparison of effective degrees of freedom.  This calculation seems unstable.
Be more careful with my fractions.
src/linearmixedmodel.jl Outdated Show resolved Hide resolved
@dmbates dmbates merged commit 845305a into main Aug 22, 2021
@dmbates dmbates deleted the db/leverage branch August 22, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants