Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructor for MixedModel dispatches to subtype #572

Merged
merged 2 commits into from Sep 17, 2021
Merged

Conversation

palday
Copy link
Member

@palday palday commented Sep 17, 2021

As previously discussed (since users can already just specify write fit(MixedModel, ....)

@palday palday requested a review from dmbates September 17, 2021 15:24
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #572 (04b7003) into main (694faa1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 04b7003 differs from pull request most recent head 99bd31a. Consider uploading reports for the commit 99bd31a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   96.24%   96.25%           
=======================================
  Files          28       28           
  Lines        2503     2509    +6     
=======================================
+ Hits         2409     2415    +6     
  Misses         94       94           
Impacted Files Coverage Δ
src/mixedmodel.jl 92.59% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694faa1...99bd31a. Read the comment docs.

@dmbates dmbates merged commit bf8b777 into main Sep 17, 2021
@dmbates dmbates deleted the pa/constructor branch September 17, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants