Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broaden shortestcovint to fit collection #598

Merged
merged 2 commits into from Mar 8, 2022
Merged

broaden shortestcovint to fit collection #598

merged 2 commits into from Mar 8, 2022

Conversation

palday
Copy link
Member

@palday palday commented Mar 8, 2022

I broadened the type restriction so that some of the stuff I'm working on in MixedModelsPermutations can use shortestcovint without adding needing a new method definition for MixedModelPermutation.

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@palday
Copy link
Member Author

palday commented Mar 8, 2022

If it weren't for the checklist, I would have forgotten the NEWS entry this time.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #598 (4ced8f0) into main (12a60ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          28       28           
  Lines        2695     2695           
=======================================
  Hits         2597     2597           
  Misses         98       98           
Impacted Files Coverage Δ
src/bootstrap.jl 99.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a60ba...4ced8f0. Read the comment docs.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see you have updated NEWS.md. We must maintain standards 😁

@palday palday merged commit 3d868bb into main Mar 8, 2022
@palday palday deleted the pa/covint branch March 8, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants