Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework predict docstring #603

Merged
merged 9 commits into from Apr 11, 2022
Merged

rework predict docstring #603

merged 9 commits into from Apr 11, 2022

Conversation

palday
Copy link
Member

@palday palday commented Apr 7, 2022

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

No behavioral changes, but we updated a docstring enough that a patch release might be worthwhile.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@kliegl is the new explanation clearer?

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #603 (96b82aa) into main (3d868bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          28       28           
  Lines        2695     2695           
=======================================
  Hits         2597     2597           
  Misses         98       98           
Impacted Files Coverage Δ
src/predict.jl 98.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d868bb...96b82aa. Read the comment docs.

@palday palday mentioned this pull request Apr 7, 2022
3 tasks
@palday palday requested review from dmbates and ararslan April 8, 2022 21:42
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things, otherwise LGTM.

src/predict.jl Outdated Show resolved Hide resolved
src/predict.jl Outdated Show resolved Hide resolved
Co-authored-by: Alex Arslan <ararslan@comcast.net>
@palday
Copy link
Member Author

palday commented Apr 9, 2022

@ararslan as someone who uses MixedModels but didn't write the code in question, do the descriptions of the options for new_re_levels make sense ?

@kliegl
Copy link

kliegl commented Apr 9, 2022

@palday How about including a sentence: Random effects (not only fixed effects) are included for predictions involving grouping variables with observed levels.

@palday palday merged commit 7f2b621 into main Apr 11, 2022
@palday palday deleted the pa/predictdocs branch April 11, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants