-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework predict
docstring
#603
Conversation
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 28 28
Lines 2695 2695
=======================================
Hits 2597 2597
Misses 98 98
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things, otherwise LGTM.
Co-authored-by: Alex Arslan <ararslan@comcast.net>
@ararslan as someone who uses MixedModels but didn't write the code in question, do the descriptions of the options for |
@palday How about including a sentence: Random effects (not only fixed effects) are included for predictions involving grouping variables with observed levels. |
… into pa/predictdocs
Thanks for contributing!
Did behavior change? Did you add need features? If so, please update NEWS.md
docs/NEWS-update.jl
to update the cross-references.No behavioral changes, but we updated a docstring enough that a patch release might be worthwhile.
Should we release your changes right away? If so, bump the version:
@kliegl is the new explanation clearer?