Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set Julia minimum compat to 1.8 #665

Merged
merged 4 commits into from Feb 7, 2023
Merged

set Julia minimum compat to 1.8 #665

merged 4 commits into from Feb 7, 2023

Conversation

palday
Copy link
Member

@palday palday commented Feb 7, 2023

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@palday palday requested a review from dmbates February 7, 2023 16:50
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 96.42% // Head: 96.15% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (1ae73fe) compared to base (5bf6b64).
Patch has no changes to coverable lines.

❗ Current head 1ae73fe differs from pull request most recent head b4060a3. Consider uploading reports for the commit b4060a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   96.42%   96.15%   -0.27%     
==========================================
  Files          29       28       -1     
  Lines        2739     2733       -6     
==========================================
- Hits         2641     2628      -13     
- Misses         98      105       +7     
Impacted Files Coverage Δ
src/linalg/pivot.jl 90.00% <0.00%> (-10.00%) ⬇️
src/serialization.jl 90.62% <0.00%> (-3.13%) ⬇️
src/linalg.jl 98.24% <0.00%> (-1.76%) ⬇️
src/randomeffectsterm.jl 95.00% <0.00%> (-1.25%) ⬇️
src/generalizedlinearmixedmodel.jl 90.24% <0.00%> (-0.31%) ⬇️
src/remat.jl 96.73% <0.00%> (-0.26%) ⬇️
src/MixedModels.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and for updating the version of ubuntu on which the checks are made.

@palday palday merged commit cdf13e9 into main Feb 7, 2023
@palday palday deleted the pa/ci18 branch February 7, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants