Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks, single global contrasts Dict #667

Merged
merged 3 commits into from Feb 22, 2023
Merged

Update benchmarks, single global contrasts Dict #667

merged 3 commits into from Feb 22, 2023

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Feb 21, 2023

  • Revise benchmark code for modern Julia
  • Change the global contrasts to a single Dict{Symbol,Any} instead of a Dict of Dicts.

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

No need to release these changes right away.

@dmbates dmbates requested a review from palday February 21, 2023 21:44
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 96.27% // Head: 96.27% // No change to project coverage 👍

Coverage data is based on head (7270567) compared to base (cdf13e9).
Patch has no changes to coverable lines.

❗ Current head 7270567 differs from pull request most recent head fbd7805. Consider uploading reports for the commit fbd7805 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          29       29           
  Lines        2739     2739           
=======================================
  Hits         2637     2637           
  Misses        102      102           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
@dmbates dmbates merged commit cb6bb41 into main Feb 22, 2023
@dmbates dmbates deleted the pkgbenchmark branch February 22, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants