Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better compatibility with RegressionFormulae.jl #677

Merged
merged 2 commits into from
Apr 14, 2023
Merged

better compatibility with RegressionFormulae.jl #677

merged 2 commits into from
Apr 14, 2023

Conversation

palday
Copy link
Member

@palday palday commented Apr 14, 2023

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

Copy link
Member

@kleinschmidt kleinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the <:MixedModel restriction on the apply_schema method SHOULD mean that the @formula time still works as intended...but maybe worth checking even informally that this still works with RegressionFormulae.jl loaded?

@palday
Copy link
Member Author

palday commented Apr 14, 2023

julia> using MixedModels, RegressionFormulae

julia> using MixedModels: dataset

julia> psts = dataset(:pastes)
Arrow.Table with 60 rows, 3 columns, and schema:
 :batch     String
 :cask      String
 :strength  Float64

julia> m = fit(MixedModel, @formula(strength ~ 1 + (1|batch/cask)), psts; progress=false)
Linear mixed model fit by maximum likelihood
 strength ~ 1 + (1 | batch) + (1 | batch & cask)
   logLik   -2 logLik     AIC       AICc        BIC    
  -123.9972   247.9945   255.9945   256.7217   264.3718

Variance components:
                Column   Variance Std.Dev. 
batch & cask (Intercept)  8.433617 2.904069
batch        (Intercept)  1.199180 1.095071
Residual                  0.678002 0.823409
 Number of obs: 60; levels of grouping factors: 30, 10

  Fixed-effects parameters:
─────────────────────────────────────────────────
               Coef.  Std. Error      z  Pr(>|z|)
─────────────────────────────────────────────────
(Intercept)  60.0533    0.642136  93.52    <1e-99
─────────────────────────────────────────────────

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (8ae74f7) 95.90% compared to head (160ed17) 95.77%.

❗ Current head 160ed17 differs from pull request most recent head 5312171. Consider uploading reports for the commit 5312171 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   95.90%   95.77%   -0.13%     
==========================================
  Files          29       28       -1     
  Lines        2733     2725       -8     
==========================================
- Hits         2621     2610      -11     
- Misses        112      115       +3     
Impacted Files Coverage Δ
src/randomeffectsterm.jl 95.34% <ø> (-1.21%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palday palday merged commit 564ce23 into main Apr 14, 2023
7 checks passed
@palday palday deleted the pa/regform branch April 14, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants