Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo #634, return Table not DictTable #682

Merged
merged 4 commits into from Apr 25, 2023
Merged

undo #634, return Table not DictTable #682

merged 4 commits into from Apr 25, 2023

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Apr 25, 2023

  • Return a TypedTables.Table not a DictTable in raneftables. Manipulation of a DictTable becomes too awkward for anything other than extracting a row by key.

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (564ce23) 95.90% compared to head (8c179ac) 95.90%.

❗ Current head 8c179ac differs from pull request most recent head a61ce08. Consider uploading reports for the commit a61ce08 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          29       29           
  Lines        2732     2732           
=======================================
  Hits         2620     2620           
  Misses        112      112           
Impacted Files Coverage Δ
src/MixedModels.jl 100.00% <100.00%> (ø)
src/mixedmodel.jl 91.22% <100.00%> (ø)
src/randomeffectsterm.jl 96.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmbates dmbates marked this pull request as ready for review April 25, 2023 14:29
@dmbates dmbates requested a review from palday April 25, 2023 14:32
src/mixedmodel.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dmbates
Copy link
Collaborator Author

dmbates commented Apr 25, 2023

@palday I don't agree with the suggestion of the formatter bot but I suppose that if we ignore the suggestion it will just keep repeating it. Shall we follow its misguided directions?

Comment on lines +95 to 97
return Table(
[NamedTuple{nms}((l, view(mat, :, i)...),) for (i, l) in enumerate(trm.levels)]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Table(
[NamedTuple{nms}((l, view(mat, :, i)...),) for (i, l) in enumerate(trm.levels)]
)
nt = [NamedTuple{nms}((l, view(mat, :, i)...),) for (i, l) in enumerate(trm.levels)]
return Table(nt)

@palday
Copy link
Member

palday commented Apr 25, 2023

@dmbates woops I missed your comment before accepting the bot's suggestion. I've made an alternative suggestion that will hopefully appease the bot and still be legible.

@dmbates dmbates merged commit 421fe21 into main Apr 25, 2023
8 checks passed
@dmbates dmbates deleted the undo634 branch April 25, 2023 15:59
@dmbates
Copy link
Collaborator Author

dmbates commented Apr 25, 2023

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants