Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative error messages #698

Merged
merged 8 commits into from Aug 9, 2023
Merged

More informative error messages #698

merged 8 commits into from Aug 9, 2023

Conversation

palday
Copy link
Member

@palday palday commented Jul 7, 2023

  • More informative error messages when passing a Distribution or Link type instead of the desired instance.
  • More informative error message on the intentional decision not to define methods for the coefficient of determination.
  • NB: we still don't export r2 or adjr2 but these functions might be scope from some other package. We just define methods for them.

Not sure how I feel about adding in these safety features -- @dmbates please feel free to reject all or part of this.

inspired by #696 and #697

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

src/generalizedlinearmixedmodel.jl Outdated Show resolved Hide resolved
src/generalizedlinearmixedmodel.jl Outdated Show resolved Hide resolved
src/mixedmodel.jl Outdated Show resolved Hide resolved
src/mixedmodel.jl Outdated Show resolved Hide resolved
src/mixedmodel.jl Outdated Show resolved Hide resolved
palday and others added 2 commits July 7, 2023 02:32
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (5ade8c4) 95.72% compared to head (bf2b1ec) 95.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   95.72%   95.82%   +0.10%     
==========================================
  Files          35       35              
  Lines        3226     3259      +33     
==========================================
+ Hits         3088     3123      +35     
+ Misses        138      136       -2     
Flag Coverage Δ
current 95.82% <100.00%> (+0.10%) ⬆️
minimum 95.72% <100.00%> (+0.10%) ⬆️
nightly 95.82% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/generalizedlinearmixedmodel.jl 90.36% <100.00%> (+0.11%) ⬆️
src/linalg/rankUpdate.jl 98.30% <100.00%> (+0.10%) ⬆️
src/linearmixedmodel.jl 94.97% <100.00%> (+0.09%) ⬆️
src/mixedmodel.jl 92.53% <100.00%> (+1.30%) ⬆️
src/remat.jl 97.17% <100.00%> (+0.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday merged commit c99a2d3 into main Aug 9, 2023
10 checks passed
@palday palday deleted the pa/trap branch August 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants