Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate hide_progress #717

Merged
merged 5 commits into from Sep 12, 2023
Merged

deprecate hide_progress #717

merged 5 commits into from Sep 12, 2023

Conversation

palday
Copy link
Member

@palday palday commented Sep 11, 2023

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

src/bootstrap.jl Outdated Show resolved Hide resolved
src/utilities.jl Outdated Show resolved Hide resolved
src/utilities.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/bootstrap.jl 100.00%
src/utilities.jl 100.00%

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Benchmark Report for /home/runner/work/MixedModels.jl/MixedModels.jl

Job Properties

  • Time of benchmarks:
    • Target: 12 Sep 2023 - 07:59
    • Baseline: 12 Sep 2023 - 08:05
  • Package commits:
    • Target: b50570
    • Baseline: 69675c
  • Julia commits:
    • Target: bed2cd
    • Baseline: bed2cd
  • Julia command flags:
    • Target: None
    • Baseline: -Cnative,-J/opt/hostedtoolcache/julia/1.9.3/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update(); Pkg.add(["BenchmarkTools", "StatsModels"])
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["crossed", "kb07:1"] 0.00 (5%) ✅ 0.00 (1%) ✅
["crossed", "ml1m:1"] 0.90 (5%) ✅ 0.76 (1%) ✅
["crossed", "mrk17_exp1:1"] 0.01 (5%) ✅ 0.19 (1%) ✅
["crossedvector", "d3:1"] 0.76 (5%) ✅ 0.48 (1%) ✅
["crossedvector", "mrk17_exp1:2"] 0.91 (5%) ✅ 0.65 (1%) ✅
["singlevector", "sleepstudy:3"] 0.00 (5%) ✅ 0.00 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["crossed"]
  • ["crossedvector"]
  • ["nested"]
  • ["singlevector"]

Julia versioninfo

Target

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       5322 s          0 s        180 s        759 s          0 s
       #2  2793 MHz       1600 s          0 s        208 s       4435 s          0 s
  Memory: 6.7694854736328125 GB (4729.109375 MB free)
  Uptime: 633.06 sec
  Load Avg:  1.0  1.03  0.68
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       8596 s          0 s        260 s        960 s          0 s
       #2  2793 MHz       2743 s          0 s        287 s       6763 s          0 s
  Memory: 6.7694854736328125 GB (4856.109375 MB free)
  Uptime: 988.72 sec
  Load Avg:  1.02  1.26  0.97
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

@palday palday requested a review from dmbates September 12, 2023 07:37
@palday palday merged commit 37b8d38 into main Sep 12, 2023
11 checks passed
@palday palday deleted the pa/progress branch September 12, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants