Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of dependencies, comment out @debug calls #733

Merged
merged 5 commits into from Dec 5, 2023
Merged

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Dec 5, 2023

  • Comment out calls to @debug
  • Update compat entries for dependencies
  • Change argument name in call to Aqua.test_all

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@dmbates dmbates requested a review from palday December 5, 2023 18:21
src/Xymat.jl Outdated Show resolved Hide resolved
src/grouping.jl Outdated Show resolved Hide resolved
src/grouping.jl Outdated Show resolved Hide resolved
src/grouping.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (774c809) 96.33% compared to head (41348d8) 96.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   96.33%   96.32%   -0.01%     
==========================================
  Files          34       34              
  Lines        3355     3350       -5     
==========================================
- Hits         3232     3227       -5     
  Misses        123      123              
Flag Coverage Δ
current 96.32% <ø> (-0.01%) ⬇️
minimum 96.22% <ø> (-0.01%) ⬇️
nightly 96.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Benchmark Report for /home/runner/work/MixedModels.jl/MixedModels.jl

Job Properties

  • Time of benchmarks:
    • Target: 5 Dec 2023 - 18:40
    • Baseline: 5 Dec 2023 - 18:45
  • Package commits:
    • Target: f2a523
    • Baseline: 7a1124
  • Julia commits:
    • Target: 8e5136
    • Baseline: 8e5136
  • Julia command flags:
    • Target: None
    • Baseline: -Cnative,-J/opt/hostedtoolcache/julia/1.9.4/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update(); Pkg.add(["BenchmarkTools", "StatsModels"])
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["crossed", "insteval:1"] 0.72 (5%) ✅ 1.00 (1%)
["crossed", "ml1m:1"] 0.87 (5%) ✅ 0.76 (1%) ✅
["crossed", "mrk17_exp1:1"] 0.01 (5%) ✅ 0.19 (1%) ✅
["crossedvector", "d3:1"] 0.64 (5%) ✅ 0.45 (1%) ✅
["crossedvector", "kb07:3"] 0.47 (5%) ✅ 1.00 (1%)
["crossedvector", "mrk17_exp1:2"] 0.73 (5%) ✅ 0.65 (1%) ✅
["singlevector", "sleepstudy:3"] 0.00 (5%) ✅ 0.00 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["crossed"]
  • ["crossedvector"]
  • ["nested"]
  • ["singlevector"]

Julia versioninfo

Target

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       1283 s          0 s        340 s       3769 s          0 s
       #2  3244 MHz       1522 s          0 s        590 s       3288 s          0 s
       #3  2602 MHz       1811 s          0 s        172 s       3408 s          0 s
       #4  2593 MHz       2014 s          0 s        164 s       3217 s          0 s
  Memory: 15.60689926147461 GB (13541.4609375 MB free)
  Uptime: 542.09 sec
  Load Avg:  1.69  1.37  0.73
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       2126 s          0 s        480 s       5429 s          0 s
       #2  2612 MHz       2621 s          0 s        748 s       4673 s          0 s
       #3  3242 MHz       3005 s          0 s        306 s       4724 s          0 s
       #4  3206 MHz       2902 s          0 s        265 s       4870 s          0 s
  Memory: 15.60689926147461 GB (13752.14453125 MB free)
  Uptime: 806.91 sec
  Load Avg:  1.44  1.52  0.98
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

@dmbates
Copy link
Collaborator Author

dmbates commented Dec 5, 2023

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

@dmbates dmbates merged commit 8214336 into main Dec 5, 2023
11 of 12 checks passed
@dmbates dmbates deleted the db/nodebug branch December 5, 2023 19:01
@dmbates dmbates mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants