Fix simulate! when only the estimable coefficients are provided
#756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
….jl into pa/simulate_fixef
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 96.45% 96.87% +0.42%
==========================================
Files 34 34
Lines 3354 3358 +4
==========================================
+ Hits 3235 3253 +18
+ Misses 119 105 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ararslan
approved these changes
Mar 25, 2024
| padding = length(model.feterm.piv) - m.feterm.rank | ||
| append!(β, fill(-0.0, padding)) | ||
| if length(β) == length(m.feterm.piv) | ||
| # unlike LMM, GLMM stores the truncated, pivoted vector directly |
There was a problem hiding this comment.
Tangential to this PR but it could be convenient to have some kind of pivot accessor to retrieve this array.
Co-authored-by: Alex Arslan <ararslan@comcast.net>
ararslan
reviewed
Mar 25, 2024
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #741
Did behavior change? Did you add need features? If so, please update NEWS.md
docs/NEWS-update.jlto update the cross-references.Should we release your changes right away? If so, bump the version: