Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using StidedMatrix? #96

Closed
oxinabox opened this issue Jun 6, 2019 · 2 comments
Closed

Stop using StidedMatrix? #96

oxinabox opened this issue Jun 6, 2019 · 2 comments

Comments

@oxinabox
Copy link
Contributor

oxinabox commented Jun 6, 2019

StridedMatrix is a annoying impossible extend union type.
it is not too hard for a custom array type to implement all the required methods.
(especially if it is a wrapper type that just delegates them all),

However it is not possible for a new type to join a Union.

I suggest that all dispatches on StridedMatrix in the package be replaced with AbstractMatrix.
If that throws an error deeper in the code because they hit some method that actually needs a StridedMatrix and they don't have the methods needed then so be it.

@btmit
Copy link

btmit commented Feb 12, 2021

A specific example that would benefit from this change:

n = 8
a = rand(n, n)
a = PDMat(a * a')

b = UpperTriangular(rand(n, n))
X_A_Xt(a, b)

should be faster than

X_A_Xt(a, Matrix(b))

@devmotion
Copy link
Member

Was fixed by #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants