Fix float NA issues on Win32 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyst
force-pushed
the
ast/fix_float_na
branch
from
e8734cc
to
ffbe7a2
Compare
|
Dunno how much it matters if at all, but it might be a good idea to rebase out the commits from my branch. If you want, you can do so using |
|
Okay, sounds good. Thanks for this, by the way! |
alyst
force-pushed
the
ast/fix_float_na
branch
from
ffbe7a2
to
dd5978b
Compare
alyst
force-pushed
the
ast/fix_float_na
branch
from
dd5978b
to
2df13fa
Compare
|
I can hardly express how satisfying it is to see AppVeyor green for once. Nice work! |
|
Currently I'm checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests failing on Win32 due to JuliaLang/julia#17195.
Largely based on JuliaData/DataFrames.jl#1006.
Should be merged to the master after #2.