-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RealFP types too restrictive for signalcorr.jl methods #459
Comments
This code is quite old, it probably just hasn't been updated. As you can see, the error is due to the lack of an appropriate |
Hm - possibly. Thanks @nalimilan. I will check that for ForwardDiff. It will for sure help with things like BigFloats, which is another limitation the current code has. Just so I can understand here, though, what we are doing with these If so, that looks like the promotion methods built in to julia. Is there a reason not to use those built in promotion methods? |
To answer my own question, I suppose the answer here is in the docs:
It sounds like this policy is contentious. So presumably this is our logic in StatsBase, that for operations in |
No wait! we do allow precision loss, since |
Yes, actually Anyway, even if you use a small input type, you may want to perform computations in |
Fixed by #567. |
the methods in
signcorr.jl
require arrays ofRealFP
types;This seems to me to be too restrictive since it, for example, the Dual types used by ForwardDiff.jl, and prevents differentiating through these functions.
Does anyone know a reason that we have this restriction? If I can get some clues about the reasons for this design choice I can propose a patch.
The text was updated successfully, but these errors were encountered: