-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there support for a StatsModelsAPI for method stubs only? #625
Comments
Sounds great to me. |
I think the main question (as I think was discussed on slack) is how opinionated these functions are meant to be about the actual API. At one end of the spectrum, such a package could simply provide the function definitions so people don't get conflicts when they try to use different packages which provide some kind of |
@ablaom Do you think MLJ and StatsModels could agree on a relatively precise definition what |
Well, how precise do we really need to avoid problems? I'm asking because I'm not sure I appreciate all the possibilities for abuse. What's wrong with
? |
Strictly speaking, to "avoid problems" we just need to forbid type piracy so that packages don't conflict. But usually in Julia methods overriding a common function are expected to have some degree of consistency -- otherwise we keep them as separate function. I'd say your proposal fills these two criteria. In this particular case, as @kleinschmidt noted, it would be interesting to see whether we can agree on whether rows represent observations (like in Tables and StatsModels) or variables (like in MultivariateStats). Do you have requirements aobut it? Also, regarding Finally, |
@nalimilan Thanks for that.
In that case, my proposal is probably too ambitious.
Currently, for our model What I am describing applies to our
In MLJ |
On further reflection, I think will instead put my efforts into a StatisticalTraits.jl package that focuses on traits shared by models and metrics, as we developed for use in MLJ. It seems that the Thanks again for the feedback! |
What kind of functions would you define in StatisticalTraits? The name sounds quite broad so if it reflects its contents it would make sense to have some coordination with JuliaStats packages. |
OK, I don't see anything that would be common with JuliaStats packages currently. |
FWIW, I've created a StatsAPI package which currently only contains |
I wonder if there is support and interest for a StatsModelsAPI package that is just for method stubs, for extension by packages in the Stats/ML ecosystem, modelled on the DatatAPI.jl package.
From the DataAPI readme:
This question was already raised here: JuliaData/DataAPI.jl#6
I learned of this proposal in a slack discussion. I am copying my original post from that thread here:
I might be interested in creating a StatsModelsAPI package, if I could expect buy-in from StatsBase.
Supposing a number of key method stubs (no types) were extracted from https://github.com/JuliaStats/StatsBase.jl/blob/master/src/statmodels.jl and put into such a package, would the maintainers of StatsBase be prepared to add the new StatsModelsAPI as a dependency and extend the stubs? I could propose a list of proposed methods
Any other thoughts?
cc: @nalimilan @kleinschmidt @andreasnoack @DilumAluthge @lindahua @ararslan @oxinabox @johnmyleswhite
The text was updated successfully, but these errors were encountered: