Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiedrank does not support dims #848

Closed
behinger opened this issue Jan 25, 2023 · 2 comments
Closed

tiedrank does not support dims #848

behinger opened this issue Jan 25, 2023 · 2 comments

Comments

@behinger
Copy link

MWE

tiedrank(rand(10,10),dims=2)

Results in

MethodError: no method matching sortperm(::Vector{Float64}; dims=2)

something like this works

mapslices(tiedrank,rand(10,10),dims=2)

but the documentation of tiedrank states: Supports the same keyword arguments as the sort function. which made me believe, dims should work. Bug or documentation wrong?

Ultimatively, I am trying to estimate ranks of ragged/sparse matrices columns as fast as possible.

@behinger
Copy link
Author

while looking for an inplace operator on tiedrank, I stumbled upon this:
JuliaLang/julia#45211

it seems sortperm will get a dims in julia 1.9

@ParadaCarleton
Copy link
Contributor

eachslice should work as of Julia 1.9 (best to avoid dims keywords from now on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants