Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is breaking from 0.33 to 0.34 #862

Closed
Datseris opened this issue May 3, 2023 · 3 comments
Closed

What is breaking from 0.33 to 0.34 #862

Datseris opened this issue May 3, 2023 · 3 comments

Comments

@Datseris
Copy link
Contributor

Datseris commented May 3, 2023

hi there,

it would be great if you guys can edit this: https://github.com/JuliaStats/StatsBase.jl/releases/tag/v0.34.0 and add what is breaking (and hence requiring the version bump). Would make the life of many downstream developers easier as we are currently facing CompatHelper PRs but hard to judge whether we should act or just merge.

@andreasnoack
Copy link
Member

It's #840. Generally, I'd merge a CompatHelper PR if your test suite passes.

@Datseris
Copy link
Contributor Author

Datseris commented May 3, 2023

Thanks! Generally, I do this, but it also can fall victim of tests passing simply because there wasn't a test that would catch this breaking change, so I always like to look up the changelogs for breaking stuff.

@ararslan
Copy link
Member

ararslan commented May 6, 2023

it would be great if you guys can edit this: https://github.com/JuliaStats/StatsBase.jl/releases/tag/v0.34.0 and add what is breaking (and hence requiring the version bump)

Done, thanks for the suggestion!

@ararslan ararslan closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants