Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method ambiguities reported by Aqua #909

Closed
prbzrg opened this issue Dec 27, 2023 · 1 comment
Closed

Method ambiguities reported by Aqua #909

prbzrg opened this issue Dec 27, 2023 · 1 comment

Comments

@prbzrg
Copy link

prbzrg commented Dec 27, 2023

In Julia v1.10, I used Aqua to detect method ambiguities in my package impICNF/ContinuousNormalizingFlows.jl#356 and some of its report were related to this package:

Ambiguity #10
==(x::Union{StatsBase.PValue, StatsBase.TestStat}, y::Real) @ StatsBase ~/.julia/packages/StatsBase/WLz8A/src/statmodels.jl:90
==(x::Real, y::AbstractIrrational) @ Base irrationals.jl:90

Possible fix, define
  ==(::Union{StatsBase.PValue, StatsBase.TestStat}, ::AbstractIrrational)

Ambiguity #11
==(y::Real, x::Union{StatsBase.PValue, StatsBase.TestStat}) @ StatsBase ~/.julia/packages/StatsBase/WLz8A/src/statmodels.jl:91
==(x::AbstractIrrational, y::Real) @ Base irrationals.jl:89

Possible fix, define
  ==(::AbstractIrrational, ::Union{StatsBase.PValue, StatsBase.TestStat})

Ambiguity #33
StatsBase.TestStat(v) @ StatsBase ~/.julia/packages/StatsBase/WLz8A/src/statmodels.jl:80
(::Type{T})(x::Base.TwicePrecision) where T<:Number @ Base twiceprecision.jl:265

Possible fix, define
  StatsBase.TestStat(::Base.TwicePrecision)

Ambiguity #34
StatsBase.TestStat(v) @ StatsBase ~/.julia/packages/StatsBase/WLz8A/src/statmodels.jl:80
(::Type{T})(z::Complex) where T<:Real @ Base complex.jl:44

Possible fix, define
  StatsBase.TestStat(::Complex)

Ambiguity #35
StatsBase.TestStat(v) @ StatsBase ~/.julia/packages/StatsBase/WLz8A/src/statmodels.jl:80
(::Type{T})(x::AbstractChar) where T<:Union{AbstractChar, Number} @ Base char.jl:50

Possible fix, define
  StatsBase.TestStat(::AbstractChar)

I would appreciate your attention to this issue.

@devmotion
Copy link
Member

Duplicate of #861. Fixed by #866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants