Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #554

Closed
musvaage opened this issue Sep 28, 2023 · 0 comments · Fixed by #555
Closed

typos #554

musvaage opened this issue Sep 28, 2023 · 0 comments · Fixed by #555

Comments

@musvaage
Copy link
Contributor

Adjoints
Commutative
Defining
arguments
construction
developer
indentation
inline
maintained
occurrence
rewriters

$ grep -nr ADjoints SymbolicUtils.jl
SymbolicUtils.jl/src/SymbolicUtils.jl:66:# ADjoints
$ grep -nr Commutatative SymbolicUtils.jl
SymbolicUtils.jl/page/representation.md:5:The most basic term representation simply holds a function call and stores the function and the arguments it is called with. This is done by the `Term` type in SymbolicUtils. Functions that aren't commutative or associative, such as `sin` or `hypot` are stored as `Term`s. Commutatative and associative operations like `+`, `*`, and their supporting operations like `-`, `/` and `^`, when used on terms of type `<:Number`, stand to gain from the use of more efficient datastrucutres.
SymbolicUtils.jl/docs/src/manual/representation.md:5:The most basic term representation simply holds a function call and stores the function and the arguments it is called with. This is done by the `Term` type in SymbolicUtils. Functions that aren't commutative or associative, such as `sin` or `hypot` are stored as `Term`s. Commutatative and associative operations like `+`, `*`, and their supporting operations like `-`, `/` and `^`, when used on terms of type `<:Number`, stand to gain from the use of more efficient datastrucutres.
$ grep -nr Definining SymbolicUtils.jl
SymbolicUtils.jl/page/interface.md:25:methods are defined. Definining these three should allow use
$ grep -nr arugments SymbolicUtils.jl
SymbolicUtils.jl/src/rule.jl:172:LHS can be any possibly nested function call expression where any of the arugments can
SymbolicUtils.jl/src/types.jl:874:The output symtype of applying variable `f` to arugments of symtype `arg_symtypes...`.
$ grep -nr condtruction SymbolicUtils.jl
SymbolicUtils.jl/test/fuzzlib.jl:64:               3 .=> [ifelse]) # cond will still stay in bool by condtruction
$ grep -nr develper SymbolicUtils.jl
SymbolicUtils.jl/README.md:28:If you are a Julia package develper in need of a rule rewriting system for your own types, have a look at the [interfacing guide](https://symbolicutils.juliasymbolics.org/interface/).
$ grep -nr identation SymbolicUtils.jl
SymbolicUtils.jl/page/config.md:117:  - code_output_indent: how much left-identation to add for "output blocks"
$ grep -nr inlline SymbolicUtils.jl
SymbolicUtils.jl/src/code.jl:451:@inlline function create_array(::Type{<:MyArray}, T, ::Val{dims}, elems...) where dims
$ grep -nr maintainted SymbolicUtils.jl
SymbolicUtils.jl/page/representation.md:19:$p / q$ is represented by `Div(p, q)`. The result of `*` on `Div` is maintainted as a `Div`. For example, `Div(p_1, q_1) * Div(p_2, q_2)` results in `Div(p_1 * p_2, q_1 * q_2)` and so on. The effect is, in `Div(p, q)`, `p` or `q` or, if they are Mul, any of their multiplicands is not a Div. So `Mul`s must always be nested inside a `Div` and can never show up immediately wrapping it. This rule sets up an expression so that it helps the `simplify_fractions` procedure described two sections below.
SymbolicUtils.jl/docs/src/manual/representation.md:19:$p / q$ is represented by `Div(p, q)`. The result of `*` on `Div` is maintainted as a `Div`. For example, `Div(p_1, q_1) * Div(p_2, q_2)` results in `Div(p_1 * p_2, q_1 * q_2)` and so on. The effect is, in `Div(p, q)`, `p` or `q` or, if they are Mul, any of their multiplicands is not a Div. So `Mul`s must always be nested inside a `Div` and can never show up immediately wrapping it. This rule sets up an expression so that it helps the `simplify_fractions` procedure described two sections below.
$ grep -nr occurance SymbolicUtils.jl
SymbolicUtils.jl/page/rewrite.md:77:Similarly `~~x::g` is a way of attaching a predicate `g` to a segment variable. In the case of segment variables `g` gets a vector of 0 or more expressions and must return a boolean value. If the same slot or segment variable appears twice in the matcher pattern, then at most one of the occurance should have a predicate.
SymbolicUtils.jl/docs/src/manual/rewrite.md:77:Similarly `~~x::g` is a way of attaching a predicate `g` to a segment variable. In the case of segment variables `g` gets a vector of 0 or more expressions and must return a boolean value. If the same slot or segment variable appears twice in the matcher pattern, then at most one of the occurance should have a predicate.
$ grep -nr orovides SymbolicUtils.jl
SymbolicUtils.jl/src/interface.jl:48:If x is a term satisfying `istree(x)` and your term type `T` orovides
$ grep -nr rewirters SymbolicUtils.jl
SymbolicUtils.jl/page/rewrite.md:136:It has been some work. Fortunately rules may be [chained together](#chaining rewriters) into more sophisticated rewirters to avoid manual application of the rules.
SymbolicUtils.jl/docs/src/manual/rewrite.md:136:It has been some work. Fortunately rules may be [chained together](#chaining rewriters) into more sophisticated rewirters to avoid manual application of the rules.
$ 

perhaps the intention here is provides an

$ ed -s SymbolicUtils.jl/src/interface.jl <<<'45,52p'
"""
  unsorted_arguments(x::T)

If x is a term satisfying `istree(x)` and your term type `T` orovides
and optimized implementation for storing the arguments, this function can 
be used to retrieve the arguments when the order of arguments does not matter 
but the speed of the operation does.
"""
$ 
@musvaage musvaage mentioned this issue Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant